Skip to content

Add explicit notification level support#88

Open
mycroes wants to merge 3 commits into
jenkinsci:masterfrom
mycroes:notify
Open

Add explicit notification level support#88
mycroes wants to merge 3 commits into
jenkinsci:masterfrom
mycroes:notify

Conversation

@mycroes

@mycroes mycroes commented Mar 12, 2025

Copy link
Copy Markdown

Adds a notify property for gerritReview that can be set explicitly. This permits the user to avoid the implicit NotifyHandling.ALL default when no value is set.

This PR solves part of JENKINS-73786.

Testing done

Added a corresponding unit test.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite

MarkEWaite commented Mar 12, 2025

Copy link
Copy Markdown

Thanks @mycroes . If you could submit one more change in this pull request, it should pass the checks on ci.jenkins.io, once your unit test is fixed so that it passes.

Run the command mvn fmt:format and commit the change it makes to GerritEnvironmentContributor.java

That will make this pull request include the fix that is needed on the master branch for:

If you're willing to become a maintainer of the plugin, I'm sure we can find people to help with the next steps, like updating the plugin to use Java 17. We have tools that can automate many of those steps, but need a plugin maintainer to review the changes and merge them.

@mycroes

mycroes commented Mar 13, 2025

Copy link
Copy Markdown
Author

Thanks @mycroes . If you could submit one more change in this pull request, it should pass the checks on ci.jenkins.io, once your unit test is fixed so that it passes.

Run the command mvn fmt:format and commit the change it makes to GerritEnvironmentContributor.java

That will make this pull request include the fix that is needed on the master branch for:

I assumed I'd rebase on #87, but included it now.

If you're willing to become a maintainer of the plugin, I'm sure we can find people to help with the next steps, like updating the plugin to use Java 17. We have tools that can automate many of those steps, but need a plugin maintainer to review the changes and merge them.

Sure, I would definitely need some help getting the tests into functioning state, but might be enough if there's a comparable plugin on pipeline workflow level (and someone can point me to that). Let me know how to proceed on this.

Thanks for your help and guidance!

@felipecrs

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants