Drastically reduce amount of API calls when checking if something exists#1500
Draft
mdealer wants to merge 4 commits intojenkinsci:masterfrom
Draft
Drastically reduce amount of API calls when checking if something exists#1500mdealer wants to merge 4 commits intojenkinsci:masterfrom
mdealer wants to merge 4 commits intojenkinsci:masterfrom
Conversation
…g. Jenkinsfile) exists. This avoids fetching directory contents, of which there could be thousands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This avoids fetching directory contents, of which there could be thousands, when looking for Jenkinsfiles. In a scenario with 500+ repos, 1000+ branches each and 1000+ files on root level this plugin otherwise does not work due to excessive API calls and throttling.
I have been running this change for months now, originally I could not use the plugin without this change. This is a pure behind the scenes API usage change.
Regarding tests, I am a bit confused about how to fix them as they seem to touch this change but also are actually testing something entirely different (like caching). I need to work on them, but someone should look over this as I don't fully understand how they are organized. There are some assumptions about the API querying directory contents on a single file stat, which is kinda convoluted.
Live test shows no issues (we use Jenkinsfile at various places, thousands of branches across hundreds of repos).
The change may help with tickets like #1459
Submitter checklist
Reviewer checklist
Documentation changes