JENKINS-24629 Incorrect quoting of environment variables#12
Open
jonaldomo wants to merge 1 commit intojenkinsci:masterfrom
Open
JENKINS-24629 Incorrect quoting of environment variables#12jonaldomo wants to merge 1 commit intojenkinsci:masterfrom
jonaldomo wants to merge 1 commit intojenkinsci:masterfrom
Conversation
|
I'm facing the same issue, would love to see this PR get merged in. I think the real bug is in https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/util/ArgumentListBuilder.java but this would still be a nice option to have. |
|
This PR is missing the suppressBuildEnvVars in the GrailsBuilderIntegrationTest GrailsBuilder constructor. Please update the PR. |
Author
|
@robertoschwald updated. |
|
The PR causes a NPE if installing plugin version on jenkins with existing projects, since suppressBuildEnvVars Boolean is null in this case and unboxing to boolean in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.