Skip to content

JENKINS-24629 Incorrect quoting of environment variables#12

Open
jonaldomo wants to merge 1 commit intojenkinsci:masterfrom
jonaldomo:master
Open

JENKINS-24629 Incorrect quoting of environment variables#12
jonaldomo wants to merge 1 commit intojenkinsci:masterfrom
jonaldomo:master

Conversation

@jonaldomo
Copy link
Copy Markdown

No description provided.

@gcase
Copy link
Copy Markdown

gcase commented Feb 6, 2016

I'm facing the same issue, would love to see this PR get merged in. I think the real bug is in https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/util/ArgumentListBuilder.java but this would still be a nice option to have.

@robertoschwald
Copy link
Copy Markdown

This PR is missing the suppressBuildEnvVars in the GrailsBuilderIntegrationTest GrailsBuilder constructor. Please update the PR.

@jonaldomo
Copy link
Copy Markdown
Author

@robertoschwald updated.

@robertoschwald
Copy link
Copy Markdown

robertoschwald commented Oct 18, 2017

The PR causes a NPE if installing plugin version on jenkins with existing projects, since suppressBuildEnvVars Boolean is null in this case and unboxing to boolean in if (suppressBuildEnvVars){} happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants