Skip to content

Assign properties to lockable resources and retrieve them in environment variables#392

Closed
mPokornyETM wants to merge 0 commit intojenkinsci:masterfrom
mPokornyETM:eidosmontreal-lockables-with-properties
Closed

Assign properties to lockable resources and retrieve them in environment variables#392
mPokornyETM wants to merge 0 commit intojenkinsci:masterfrom
mPokornyETM:eidosmontreal-lockables-with-properties

Conversation

@mPokornyETM
Copy link
Contributor

(This replaces #299 because we has no write permission to origin branch)

See JENKINS-XXXXX.

See #XXXXX

note
todo:

  • I am not pretty sure now. There are a lot of PR to this point, but I can not find any issue. But I will try it again and in case there is no one I will create it.
  • close related PRs
  • update documentation
  • check test code coverage
  • localizations
  • try to merge with Data tables #375

Testing done

Proposed changelog entries

  • Entry 1: Assign properties to lockable resources and retrieve them in environment variables

Proposed upgrade guidelines

N/A

Localizations

  • English
  • Slovak
  • Czech
  • France

Submitter checklist

  • The Jira / Github issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during the upgrade.
  • There is automated testing or an explanation that explains why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease the future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.
  • Any localizations are transfered to *.properties files.

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There is at least one (1) approval for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • java code changes are tested by automated test.

@mPokornyETM mPokornyETM added enhancement work-in-progress java Pull requests that update Java code ui Features that may impact UI, pages made by the plugin or external UIs (BO, legacy, etc.) documentation extended properties Ideas about more aspects of the lockable resource instances than we had before new parameters/features test localization labels Nov 6, 2022
@mPokornyETM mPokornyETM self-assigned this Nov 6, 2022
@mPokornyETM mPokornyETM closed this Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation enhancement extended properties Ideas about more aspects of the lockable resource instances than we had before java Pull requests that update Java code localization new parameters/features test ui Features that may impact UI, pages made by the plugin or external UIs (BO, legacy, etc.) work-in-progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant