[JENKINS-68480] Automatically select owner for GitHubAppCredentials#117
Merged
aaronwalker merged 1 commit intojenkinsci:masterfrom Apr 4, 2023
Merged
[JENKINS-68480] Automatically select owner for GitHubAppCredentials#117aaronwalker merged 1 commit intojenkinsci:masterfrom
aaronwalker merged 1 commit intojenkinsci:masterfrom
Conversation
Author
Author
|
@aaronwalker hi, do you have a moment to review and merge this pr? Multiple dependencies have been upgraded, I believe the Jenkinsfile also needs to be upgraded , I ran the compile on my pc and it works. |
Member
|
@LeoQuote looks like an issue with the CI See https://github.com/jenkinsci/pipeline-github-plugin/runs/12449680268 |
Author
|
@aaronwalker Thanks for your review, IMHO the error is caused by the outdated build environtment, the building system is using java 8 which is not supported in the latest jenkins server. would you consider merging #118 to bring build environment to the latest? |
6 tasks
aaronwalker
requested changes
Apr 4, 2023
Member
|
@LeoQuote hate to be a pain but can you squash this into a single commit |
upgrade dependency to build
Author
|
@aaronwalker certainly, done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This pr fix https://issues.jenkins.io/browse/JENKINS-68480 ,
like jenkinsci/github-branch-source-plugin#527 , it sets RepoOwner() context automatically , make it possible to call api when using github app credentials