Fix scm accept parsing in version 3.1.0.#5
Open
ccosby wants to merge 3 commits intojenkinsci:masterfrom
ccosby:ccosby-master
Open
Fix scm accept parsing in version 3.1.0.#5ccosby wants to merge 3 commits intojenkinsci:masterfrom ccosby:ccosby-master
ccosby wants to merge 3 commits intojenkinsci:masterfrom
ccosby:ccosby-master
Conversation
added 3 commits
December 21, 2012 09:40
Patched on 0.3 release versioned 0.3.1-SNAPSHOT Also updated name of some variables to more accurately reflect their scm version requirement. Added initial research on parsing JSON output of 3.1.0 commands, but ran out of time. Included the output txt file if anyone has time to hack it in.
The JSON support here is meant as an example for future development. I don't think the Jazz JSON API is stable enough to rely on at this point, so all we're providing here is a basic HOWTO. In particular, the UUID doesn't map to one of the (1001) style descriptive numbers anywhere and the scm compare command doesn't provide the UUID for the changeset in its JSON output. Neat, huh?
|
Jenkins » rtc-plugin #6 SUCCESS |
|
It would be very nice to see this 3.1.100-specific accept-parsing code make it into the main code stream, but at the moment commit 8658d03 where that was done also includes the incomplete JSON-parsing code. It'd probably be easier for the maintainer to accept if they were separated out. |
Member
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix parsing of scm accept command in version 3.1.0. Also add experimental parsing of JSON output from scm accept command. It's only enabled when running a specific test case and isn't really useful yet.