Conversation
|
Thanks. I still see two failing tests in |
Change testthat.R add app$wait_for_idle() to test-SCD
output_app <- output_app[[1]] }
jepusto
left a comment
There was a problem hiding this comment.
Thanks for taking care of the remaining test failures. I've commented on a few points in the code where things can be cleaned up and simplified. Please attend to these and then clean up the test file by removing any extra comments that are not descriptive (e.g., # CHANGED and skip() calls that are commented out).
jepusto
left a comment
There was a problem hiding this comment.
Please add your preferred name and email to DESCRIPTION.
|
Please also remove the explicit call to xml2 in the shiny app tests, and remove |
The |
|
Thanks. Please leave a comment to let me know when you're ready for me to review the PR again. |
|
Thanks! I’ll do a final check to make sure everything is clean and will let you know when it’s ready for review |
|
I’ve made the updates and everything should be ready now. Please feel free to review again. Thanks! |
|
Closes #98. |
change shinytest to shinytest2