Skip to content

Dev: notification types, update UX, contact/event fixes, single scrollbar, UX v2 doc #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jerryagenyi merged 6 commits into from
Feb 2, 2026
Merged

Dev: notification types, update UX, contact/event fixes, single scrollbar, UX v2 doc #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8ff8765
feature: Play after device change, WhatsApp country code, stream labe…
jerryagenyi Feb 2, 2026
9f7936a
fix: Play proxy timeout handling, stream order deduplication
jerryagenyi Feb 2, 2026
1412494
Merge main into dev (sync)
jerryagenyi Feb 2, 2026
aa34433
docs: TODO updates (notification tasks, WhatsApp/Event/Contact notes)
jerryagenyi Feb 2, 2026
23bd205
feat: notification types, update UX, contact/event fixes, single scro…
jerryagenyi Feb 2, 2026
61e8b9c
PR fixes: ContactManager fetch-before-save, scoped duplicate modal, T…
jerryagenyi Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions TODO.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Context: [CLAUDE.md](CLAUDE.md), [docs/TROUBLESHOOTING.md](docs/TROUBLESHOOTING.

- [x] **Workflow/docs** — Branch workflow: feature → merge into dev locally → push dev → PR dev→main (remote only). Local branches: dev + features only; `main` deleted locally (remote-only). AGENTS.md removed; refs point to CLAUDE.md. PR #6 updated with lock-admin-localhost changes.

- [ ] **Notification types** — Different types of notification: for duplicate stream name or duplicate source, use a simple modal ("stream already exists") without troubleshooting link; for real failures, use existing error handling with diagnosis/link.
- [x] **Notification types** — For duplicate stream name or duplicate source, use a simple modal ("stream already exists") without troubleshooting link; for real failures, existing error handling with diagnosis/link. Implemented in FFmpegStreamsManager: isDuplicateError(), showDuplicateModal(); used for start, restart, update, start-all.

- [ ] **Source validation & clear errors** — On stream failure, check if source (device/file) is viable and say so in the error. Optional: "Test source" button per source. _Note: Test source button + Show test tools toggle and structured errors implemented; QA pending._

Expand All @@ -38,9 +38,11 @@ Context: [CLAUDE.md](CLAUDE.md), [docs/TROUBLESHOOTING.md](docs/TROUBLESHOOTING.

- [x] **Sortable streams (optional)** — Up/down buttons on dashboard; `POST /api/streams/reorder`; order persisted in `config/streams.json` (`_order`); listener page uses same order and S1/S2/S3 labels without refresh.

- [x] **Contact: WhatsApp** — Country code enforced (digits 10–15, no leading zero); validation backend + ContactManager; `wa.me/<digits>` built on listener page; placeholder "e.g. +44 7123 456789 (country code required)".
- [x] **Contact: WhatsApp** — Country code enforced (digits 10–15, no leading zero); validation backend + ContactManager; `wa.me/<digits>` built on listener page; placeholder "e.g. +44 7123 456789 (country code required)". Not working
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix checklist status: marked done but says “Not working”.

A checked item shouldn’t describe a broken state. Either uncheck it or split into “implemented” (checked) plus a new unchecked “fix not working” follow‑up.

🤖 Prompt for AI Agents 
In `@TODO.md` at line 41, The checklist line for "Contact: WhatsApp" is marked
complete but states "Not working"; update the TODO entry by either unchecking
that item or splitting it into two lines: keep a checked "Contact: WhatsApp —
initial implementation" and add a new unchecked follow-up like "Contact:
WhatsApp — fix validation/wa.me builder (not working)". Ensure the placeholder
text and requirements (digits 10–15, no leading zero, backend validation,
ContactManager, wa.me/<digits>) are preserved in the new lines so reviewers can
track what's implemented vs what still needs fixing.


- [ ] **Update notification UX** — Show notification bell icon when update available; click to open modal with update info and link to latest release. Current: button shows "Updates" and runs manual check on click; should auto-check on load and show bell when updateAvailable=true.
- [x] **Update notification UX** — Bell icon in header; auto-check on load (HeaderComponent.checkForUpdates); when updateAvailable=true bell shows badge and "Update Available"; click opens modal with update info and link to release. Single button id header-update-bell-btn; manual check on click when no update yet.

- [x] **Event Details & Your Contact components** — Not working as they should; details not saving for contact, and the event details collapsible doesn't open after saving details.

- [ ] **UI/UX polish (optional)** — [docs/UI-UX-RECOMMENDATIONS.md](docs/UI-UX-RECOMMENDATIONS.md).

Expand Down
Loading
Loading