perf: optimize string verification in DownloadStore#82
Open
lucifer4330k wants to merge 1 commit into
Open
Conversation
Optimized `DownloadStore::is_correct_format` by avoiding a temporary string allocation and hoisting the loop bound calculation. - Replaced `f.substr(40) != ".torrent"` with `f.compare(40, 8, ".torrent") != 0` to eliminate a temporary string object creation. - Hoisted `f.end() - 8` out of the character validation loop to avoid repeated calculation. Benchmark results showed a ~22% performance improvement for this function.
There was a problem hiding this comment.
Pull request overview
This PR optimizes DownloadStore::is_correct_format in src/core/download_store.cc by removing an avoidable temporary string allocation and reducing repeated iterator arithmetic in the validation loop.
Changes:
- Replaced
substr-based suffix checking withstd::string::compareto avoid creating a temporary string. - Hoisted
f.end() - 8into a locallastiterator to avoid recomputing it each loop iteration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimized
DownloadStore::is_correct_formatby avoiding a temporary string allocation and hoisting the loop bound calculation.f.substr(40) != ".torrent"withf.compare(40, 8, ".torrent") != 0to eliminate a temporary string object creation.f.end() - 8out of the character validation loop to avoid repeated calculation.performance improvement for this function.
#gsoc