Skip to content

OrderException: include list of params involved #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
presto8 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OrderException: include list of params involved #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions pyetrade/order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,13 +82,14 @@ def option_symbol(
class OrderException(Exception):
""":description: Exception raised when giving bad args to a method not from Etrade calls"""

def __init__(self, explanation=None, params=None) -> None:
def __init__(self, explanation: str = "", params=None) -> None:
super().__init__()
self.required = params
self.explanation = explanation or "missing required parameters"
self.required = params or []
self.args = (explanation, params)

def __str__(self) -> str:
return "Missing required parameters"
return f"{self.explanation}: {self.required}"


class ETradeOrder(object):
Expand Down Expand Up @@ -323,19 +324,20 @@ def check_order(**kwargs):
"marketSession",
]

if not all(param in kwargs for param in mandatory):
raise OrderException
missing = [param for param in mandatory if param not in kwargs]
if missing:
raise OrderException(params=missing)

if kwargs["priceType"] == "STOP" and "stopPrice" not in kwargs:
raise OrderException
raise OrderException(params=["stopPrice"])
if kwargs["priceType"] == "LIMIT" and "limitPrice" not in kwargs:
raise OrderException
raise OrderException(params=["limitPrice"])
if (
kwargs["priceType"] == "STOP_LIMIT"
and "limitPrice" not in kwargs
and "stopPrice" not in kwargs
):
raise OrderException
raise OrderException(params=["limitPrice", "stopPrice"])

@staticmethod
def build_order_payload(order_type: str, **kwargs) -> dict:
Expand Down