Expose Group.data via Data()#427
Open
jgold2-stripe wants to merge 1 commit intojessevdk:mainfrom
Open
Conversation
Author
|
@jessevdk -- Apologies if I overlooked some guide to how to contribute, but hopefully this PR makes it to you? It appears that I need approval to run the builds? LMK if there is anything I can do to help with next steps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our application, we want to walk the subcommand hierarchy and test the actual instance type of certain activated subcommands, in order to preconfigure the application in various ways based on the object type.
The part of the application processing the parsed command is separate from the part creating it, so we need this in order to access the values post-parse. Since the application already sets the value of
Group.dataimplicitly when adding a subcommand, re-exporting it should not expose anything not already exposed.