Skip to content

Added wrapper for numpy.ma.testutils#62

Merged
YaroslavMayorov merged 4 commits into
masterfrom
aleksandra/test-wrapper
Mar 17, 2026
Merged

Added wrapper for numpy.ma.testutils#62
YaroslavMayorov merged 4 commits into
masterfrom
aleksandra/test-wrapper

Conversation

@YaroslavMayorov
Copy link
Copy Markdown
Contributor

@YaroslavMayorov YaroslavMayorov commented Mar 4, 2026

No description provided.

@YaroslavMayorov YaroslavMayorov linked an issue Mar 4, 2026 that may be closed by this pull request
Change assert_array_equal to unittest's assert #52
Closed
@YaroslavMayorov YaroslavMayorov requested a review from kochaika March 4, 2026 14:21
@YaroslavMayorov
Copy link
Copy Markdown
Contributor Author

YaroslavMayorov commented Mar 4, 2026

@stephen-hero please check error messages in the test_task.py files

@kochaika kochaika requested a review from KovalevRoma March 4, 2026 14:51
@kochaika

This comment was marked as resolved.

Sign in to view
stephen-hero
stephen-hero requested changes Mar 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@stephen-hero stephen-hero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

language checked

Comment thread Bayes Guards SMS/Vectorize/tests/test_task.py Outdated
Comment thread Bayes Guards SMS/Vectorize/tests/test_task.py Outdated
Comment thread Comic-Con and K-means/Histogram/tests/test_task.py Outdated
Comment thread Comic-Con and K-means/K-means/tests/test_task.py Outdated
Comment thread Comic-Con and K-means/Reading an image/tests/test_task.py Outdated
Comment thread Comic-Con and K-means/Reading an image/tests/test_task.py Outdated
KovalevRoma
KovalevRoma suggested changes Mar 6, 2026
View reviewed changes
Copy link
Copy Markdown

@KovalevRoma KovalevRoma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Environment

OS: Windows 11, Ubuntu 22.04
IDE: PyCharm 2025.3.3

Result

In Student Mode, the author solution does not pass the validation in the following sections:

  • Neighbors and Wine / k-nearest neighbors
  • Neighbors and Wine / Leave-one-out

k-nearest_neighbors_error.txt

leave-me-out_error.txt

@kochaika kochaika requested a review from KovalevRoma March 13, 2026 15:09
@kochaika
Copy link
Copy Markdown
Contributor

kochaika commented Mar 13, 2026

@KovalevRoma
Recheck only

Neighbors and Wine / k-nearest neighbors
Neighbors and Wine / Leave-one-out

tasks

@KovalevRoma
Copy link
Copy Markdown

KovalevRoma commented Mar 16, 2026

Both tasks now work correctly.

@YaroslavMayorov YaroslavMayorov merged commit 5a37158 into master Mar 17, 2026
6 checks passed
@YaroslavMayorov YaroslavMayorov deleted the aleksandra/test-wrapper branch March 20, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kochaika kochaika kochaika approved these changes

@stephen-hero stephen-hero stephen-hero approved these changes

+1 more reviewer

@KovalevRoma KovalevRoma KovalevRoma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

proofread tested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change assert_array_equal to unittest's assert

4 participants

@YaroslavMayorov @kochaika @KovalevRoma @stephen-hero