fix: support replacing URLs mixed with CJK characters (#15)#41
Open
stellarissss wants to merge 1 commit into
Open
fix: support replacing URLs mixed with CJK characters (#15)#41stellarissss wants to merge 1 commit into
stellarissss wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR aims to resolve issue #15 regarding URLs mixed with CJK (Chinese, Japanese, Korean) characters.
Since CJK languages do not use spaces between words, URLs frequently attach directly to surrounding text (e.g.,
你好http://example.com). The current strict boundary checks miss these cases.To fix this, I added a preprocessing step inside the
replace_urlsfunction. It identifies continuous blocks containing bothhttp(s)://and CJK characters, extracts the CJK text, and replaces the URL structure with the placeholder.Because this preprocessing strictly requires a CJK character to trigger, pure English strings without spaces remain unaffected with near-zero performance overhead. Standard English URL processing is also completely unchanged.
All relevant tests passed. Please let me know if anything needs adjustment. Thanks!