Skip to content

fix: tolerate node_modules path differences in lib/ verification #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sverdlov93 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: tolerate node_modules path differences in lib/ verification #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,12 @@ jobs:
# If lib/ is not rebuilt after src/ changes, the action will run stale code.
- name: Verify lib/ is compiled and up to date
run: |
if [[ -n "$(git status lib/ --porcelain)" ]]; then
# -I ignores hunks where every changed line matches the pattern.
# Without a lockfile, npm may hoist transitive deps differently,
# causing only node_modules path comments/keys to differ in the bundle.
UNTRACKED=$(git ls-files --others --exclude-standard lib/)
MEANINGFUL_DIFF=$(git diff -I 'node_modules/' -- lib/)
if [[ -n "$UNTRACKED" || -n "$MEANINGFUL_DIFF" ]]; then
echo "::error::lib/ is out of sync with src/. Run 'npm run build' and commit the changes."
git diff -- lib/
exit 1
Expand Down
Loading