Feature/sensor observation, imu reward functions#15
Open
vybhav-ibr wants to merge 8 commits intojgillick:mainfrom
Open
Feature/sensor observation, imu reward functions#15vybhav-ibr wants to merge 8 commits intojgillick:mainfrom
vybhav-ibr wants to merge 8 commits intojgillick:mainfrom
Conversation
…ns as a seperate box, make obs_size calculation compatable with multi-dimensional arrays to support sensors
…servations as a seperate box, make obs_size calculation compatable with multi-dimensional arrays to support sensors" This reverts commit 256c98b.
… observation manager to get individual observation items
jgillick
requested changes
Dec 26, 2025
jgillick
requested changes
Jan 4, 2026
Owner
There was a problem hiding this comment.
Is this duplicated from the original example, or was it created during your training run?
Owner
There was a problem hiding this comment.
This file was directly copied without updates. The README should reflect what the example is demonstrating. Never blindly copy things and submit them for review without updating them appropriately.
| return mags.sum(dim=1) | ||
|
|
||
|
|
||
| def imu_ang_vel_jitter( |
Owner
There was a problem hiding this comment.
Same comments as imu_lin_acc_jitter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds the rate limited sensor observation function, and reward functions which use the imu measurement, makes some modifications to the observation manager to get one specific observation reading from the observation buffer