Skip to content

Feature/sensor observation, imu reward functions#15

Open
vybhav-ibr wants to merge 8 commits intojgillick:mainfrom
vybhav-ibr:feature/sensor_observation,_imu_reward_functions
Open

Feature/sensor observation, imu reward functions#15
vybhav-ibr wants to merge 8 commits intojgillick:mainfrom
vybhav-ibr:feature/sensor_observation,_imu_reward_functions

Conversation

@vybhav-ibr
Copy link
Copy Markdown

adds the rate limited sensor observation function, and reward functions which use the imu measurement, makes some modifications to the observation manager to get one specific observation reading from the observation buffer

…ns as a seperate box, make obs_size calculation compatable with multi-dimensional arrays to support sensors
…servations as a seperate box, make obs_size calculation compatable with multi-dimensional arrays to support sensors"

This reverts commit 256c98b.
… observation manager to get individual observation items
Comment thread genesis_forge/mdp/observations.py Outdated
Comment thread genesis_forge/mdp/observations.py Outdated
Comment thread genesis_forge/mdp/rewards.py
Comment thread genesis_forge/mdp/rewards.py
Comment thread genesis_forge/mdp/rewards.py Outdated
Comment thread genesis_forge/mdp/reset.py Outdated
@vybhav-ibr vybhav-ibr requested a review from jgillick December 29, 2025 11:39
Comment thread genesis_forge/mdp/rewards.py
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this duplicated from the original example, or was it created during your training run?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was directly copied without updates. The README should reflect what the example is demonstrating. Never blindly copy things and submit them for review without updating them appropriately.

return mags.sum(dim=1)


def imu_ang_vel_jitter(
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as imu_lin_acc_jitter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants