Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
tungsteniteandasync-tungstenite.But native tests didn't work because
echo.websocket.orgresponded with429 Too Many Requests. We wanted to run a local echo server for tests anyway, so I implemented it. Initially I wanted the server to be shared between tests, but for this to work you'd need to spawn it in a thread and create a tokio runtime for it. Using thetokio::testruntime doesn't seem to work because the spawned tasks for the server is terminated when a test finishes. For now every test will create a server.For wasm the server is replaced with a dummy that will use
echo.websocket.org. It seems we only get 429 when we don't use a browser. They probably limit requests from weird user agents.If CI passes, this can be merged.