fix: scrub sensitive values from logcat + gate logs behind BuildConfig.DEBUG - #12
Open
jguillaumesio wants to merge 1 commit into
Open
fix: scrub sensitive values from logcat + gate logs behind BuildConfig.DEBUG#12jguillaumesio wants to merge 1 commit into
jguillaumesio wants to merge 1 commit into
Conversation
…g.DEBUG - Redact target number (asterisks) in all log statements - Redact expected code value, log only its length - Redact trigger key in logs - Wrap all Log.d calls in BuildConfig.DEBUG guard so they are stripped from release builds - Incoming call number redacted in logcat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Sensitive values (intercom number, door code) were being logged in plaintext via Log.d. On a rooted device or via adb logcat, anyone could read them. The app controls physical access to your home — leaking these in logs is a real security issue.
Changes
Test plan