fix: use cross-platform command to open browser#1
Open
rblalock wants to merge 1 commit intojhaynie:mainfrom
Open
fix: use cross-platform command to open browser#1rblalock wants to merge 1 commit intojhaynie:mainfrom
rblalock wants to merge 1 commit intojhaynie:mainfrom
Conversation
The 'open' command is macOS-specific. This change uses the appropriate command for each platform: 'open' on macOS, 'start' on Windows, and 'xdg-open' on Linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opencommand not found error on Linux systemsopenon macOS,starton Windows,xdg-openon LinuxProblem
The CLI was hardcoded to use the
opencommand, which is macOS-specific. On Linux, this results in:Solution
Added platform detection using
process.platformto select the appropriate command:darwin(macOS):openwin32(Windows):startxdg-open