fix: add action buttons to json output#949
Open
jpagh wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes JSON/API serialization so that action_buttons defined on a question are actually included in the additional_buttons field returned by as_data(), aligning the JSON output with what the UI formatter already renders from status.extras['action_buttons'].
Changes:
- Append each processed
action_buttonsitem intoresult['additional_buttons']duringas_data()serialization.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking into using the API/json output, and realized that
action buttonsweren't being included. Upon investigation, it appears that this was due to a bug where the action buttons were created, but never appended to theadditional_buttonskey.