Fix oauth refresh#955
Open
jpagh wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses OAuth credential refresh reliability for DAOAuth by ensuring Redis-loaded credentials are reattached to storage, silently refreshed when expired and refreshable, and treated as unauthorized when expired and not refreshable. It also adds opt-in configuration knobs to customize authorization URL parameters and the redirect URL style without changing defaults.
Changes:
- Add
DAOAuthoptionsextra_auth_args(extraauthorization_url()kwargs) andurl_style_short(use short-style interview URLs for redirect URIs). - Refresh expired stored credentials in
DAOAuth.get_credentials()(via_get_stored_credentials(refresh=True)) and treat expired tokens as unauthorized when refresh is unavailable/fails. - Reattach Redis storage to credentials reloaded from JSON so refreshed tokens can be persisted.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #954
Adds the following which are things that I needed that I think others would benefit from having included, but that don't change any default behaviors: