Add read_packages permission for read-only package access#959
Open
rajeswari1301 wants to merge 1 commit into
Open
Add read_packages permission for read-only package access#959rajeswari1301 wants to merge 1 commit into
rajeswari1301 wants to merge 1 commit into
Conversation
* Add read_packages permission for read-only access * Add permission checks into existing if blocks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the
/api/packagepermission check into two separate checks: GET requests only requireread_packages, while POST and DELETE still requiremanage_packages. Old keys withmanage_packagesstill work for GET - no breaking changes.Also adds
read_packagesto PERMISSIONS_LIST so it can be selected when creating an API key. This allows API keys to be limited to read-only package access, with no permission to install or delete packages