Open
Conversation
qingshui
reviewed
May 16, 2023
Collaborator
qingshui
left a comment
qingshui
left a comment
There was a problem hiding this comment.
改一下，不要只升级自己业务，会将其它业务搞挂的
| const std::string& mask_varname, | ||
| int metric_phase, | ||
| const std::string& cmatch_rank_group, | ||
| const std::string& uid_varname, |
| py::arg("mask_varname"), | ||
| py::arg("metric_phase"), | ||
| py::arg("cmatch_rank_group"), | ||
| py::arg("uid_varname"), |
Collaborator
There was a problem hiding this comment.
这个也是属于不兼容升级，要么兼容升级，要么自己单独写一个接口，不要直接在原来接口上面增加参数，其它业务使用会挂的
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
PR changes
Describe