update read_mist_models.EEPCMD.plot_CMD#2
Open
zjzhang42 wants to merge 2 commits intojieunchoi:masterfrom
Open
update read_mist_models.EEPCMD.plot_CMD#2zjzhang42 wants to merge 2 commits intojieunchoi:masterfrom
zjzhang42 wants to merge 2 commits intojieunchoi:masterfrom
Conversation
… age (e.g., older than the Universe)
jieunchoi
reviewed
Oct 22, 2018
Owner
jieunchoi
left a comment
jieunchoi
left a comment
There was a problem hiding this comment.
Instead of only upper_age maybe give the option to provide a range of ages? Both lower_age and upper_age.
jieunchoi
approved these changes
Oct 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enable users to set an age upper limit (e.g., the age of the Universe) when plotting CMD of EEP, to avoid plot tracks with unreasonably old ages.