Add FileSystemHandle.prototype.getUniqueId() per WHATWG FS spec#95
Merged
jimmywarting merged 2 commits intomasterfrom Apr 6, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/jimmywarting/native-file-system-adapter/sessions/0c2e76c3-7f3f-4c5e-8948-85eb5b04c49a Co-authored-by: jimmywarting <1148376+jimmywarting@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add getUniqueId() to FileSystemHandle.js
Add Apr 6, 2026
FileSystemHandle.prototype.getUniqueId() per WHATWG FS spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
FileSystemHandle.prototype.getUniqueId()— a stable, per-entry UUID returned as a UUID v4-format string.Design
Identity strategy per adapter:
memory.jsnode.jskind:path) vianode:cryptocreateHashdeno.jskind:path) viacrypto.subtle.digestindexeddb.jsf/dper kindcache.jskind:path) viacrypto.subtle.digestFileSystemHandle.jsfallback — if the adapter has nogetUniqueId(), a random UUID is generated once and cached on the adapter object:Including
kindin the hash input is the key correctness detail: it ensures a file and a directory that transiently share the same path produce distinct IDs, satisfying the WPT test "a file and a directory of the same path return different IDs".Tests
FileSystemBaseHandle-getUniqueId.jsmoved fromSKIP_REASONS→SUPPORTED_SCRIPTSin bothwpt-node.jsandwpt-browser.spec.js. All 11 WPT subtests pass against both the memory and Node.js adapters.