Open
Conversation
jishnusen
reviewed
May 18, 2019
| d_constant_velocity = p_goal - d_accelerating - d_decelerating; | ||
| t_constant_velocity = d_constant_velocity / v_max; | ||
|
|
||
| t_total = t_accelerating + t_constant_velocity + t_decelerating; |
Owner
There was a problem hiding this comment.
What happens if there isn't time to reach the max velocity before reaching the goal?
jishnusen
reviewed
May 18, 2019
| const double Profile::GetTime() { | ||
| return 0.0; | ||
| // NOTE - This is a very rough draft, and not a finished product. These are just some of the calculations I will be using | ||
| const double Profile::GetTime(ProfilePoint current, ProfilePoint goal, bool use_max_velocity) { |
Owner
There was a problem hiding this comment.
This should just use the member variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to understand this problem and the calculations involved the best I could, but I'm still not quite clear on some concepts. If anything seems wrong in my code, or the calculations are incorrectly used, please feel free to tell me. Thank you!