Skip to content

darklua.process files in place #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ewd3v wants to merge 2 commits into
base: main
Choose a base branch
from
Open

darklua.process files in place #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f245fc9
darklua.process files in place
ewd3v Nov 2, 2025
64fc1e9
fix build files not being copied over
ewd3v Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions src/lib.luau
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,13 +239,39 @@ function multitarget.build(
local targetDir = pathfs.Directory.new(outputDir.path:join(target))
targetDir:writeDir() -- assure it exists (may not exist later if the user uses "includes" incorrectly, which would throw an undescriptive error later when trying to access this directory)

local globIgnore = {}
if buildFiles then
for _, buildFile in buildFiles do
local destination = targetDir.path:join(buildFile)
local parent = destination:parent()
if parent then
fs.writeDir(parent)
Copy link
Copy Markdown
Owner

@jiwonz jiwonz Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't this written already in line 240 above?

Copy link
Copy Markdown
Contributor Author

@ewd3v ewd3v Nov 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well yes in most cases the parent dir for a build file would be the targetDir, but if you input "modules/something.luau" as a build file then the parent dir would be "modules". So that code just makes sure the modules dir exist under the targetDir before writing (as fs.copy requires it).

end

fs.copy(buildFile, destination, true)

local wdFilePath = pathfs.canonicalize(buildFile):stripPrefix(workingDirPath)
if not wdFilePath then
continue
end

local wdFilePathStr = wdFilePath:toString()
if fs.isFile(buildFile) then
table.insert(globIgnore, wdFilePathStr)
elseif fs.isDir(buildFile) then
table.insert(globIgnore, wdFilePathStr .. "/**")
end
end
end

-- selene: allow(shadowing)
local newPesdeToml = tableHelper.copy(pesdeToml, true)
if newPesdeToml.includes then
for _, include in newPesdeToml.includes do
for _, path in
glob(include, {
cwd = workingDirPath,
ignore = globIgnore, -- We don't have to process these as everything in this list already got copied over in the step above
})
do
local dest = targetDir.path:join(
Expand Down Expand Up @@ -398,8 +424,8 @@ function multitarget.build(
end

for _, buildFile in buildFiles do
local darkluaOutputPath = targetDir.path:join(buildFile):toString()
darklua.process(buildFile, darkluaOutputPath, {
local targetBuildFile = targetDir.path:join(buildFile):toString()
darklua.process(targetBuildFile, targetBuildFile, {
rules = rules,
})
end
Expand Down