Stop sending cookies on HTTP requests#757
Open
jjjake wants to merge 1 commit into
Open
Conversation
All auth operations use S3Auth (Authorization: LOW header). The logged-in-user and logged-in-sig cookies were loaded into the requests.Session cookie jar and sent on every *.archive.org request, but nothing on the server side or client side depends on them for functionality. This removes the cookie jar loading from ArchiveSession.__init__. Cookie values remain accessible in self.config['cookies'] for: - self.user_email (parsed from config dict, not the jar) - `ia configure --print-cookies` (reads from config dict) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logged-in-userandlogged-in-sigcookies into therequests.Sessioncookie jar inArchiveSession.__init__S3Auth(Authorization: LOWheader) — cookies were vestigial and sent on every*.archive.orgrequest unnecessarilyself.config['cookies']forself.user_emailandia configure --print-cookiesTest plan
ruff checkpassespytest— 251 passed, 0 failuresNONEon all hops🤖 Generated with Claude Code