This repository was archived by the owner on Jun 8, 2019. It is now read-only.
Bug in FindCallingMethodOnStackTrace wrt wrapping logger#15
Open
aloker wants to merge 2 commits into
Open
Conversation
…ing a wrapper type only works if no method on a different type is present on the callstack between the wrapper type method and the NLog method.
Author
|
Proposed solution added. |
|
This has been fixed in NLog/NLog@08183ad |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added unit test that shows a bug in FindCallingMethodOnStackTrace: using a wrapper type only works if no method on a different type is present on the callstack between the wrapper type method and the NLog method.
E.g. it's not possible to get a proper stack trace when wrapping NLog 2 for Common.Logging.
I'll try to come up with a fix.