insert_sync#16
Open
jdhood1 wants to merge 146 commits intojkvor:masterfrom
jdhood1:master
Open
Conversation
Author
|
Hey Jacob, I pulled your latest code on 8/24 and put back in my changes along with others and a few bug fixes. Take a look at the latest commit and let me know what you think. Thanks. Jeremy
|
Signed-off-by: François de Metz <fdemetz@af83.com>
Signed-off-by: François de Metz <fdemetz@af83.com>
Also providing better instructions. Signed-off-by: François de Metz <fdemetz@af83.com>
undefined value have been already implemented, but doesn't follow the specifications. Signed-off-by: François de Metz <fdemetz@af83.com>
Bson value null
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Jacob,
I've been using your emongo driver for a couple of months now and love it. In reading through some of the code, it seems well thought out and solid. I appreciate that. One of my coworkers, Brad Anderson, speaks highly of you. Thanks for writing and sharing emongo. One of the MongoDB guys, Richard Kreuter, is visiting us for a couple of days and asked for a recommendation between emongo and erlmongo. They want to support an Erlang driver. I recommended they take your driver and expand on it. We'll see what comes of that.
Anyway, on to business. I saw that someone added an "update_sync" function. I thought it would be nice to have a similar one for inserts. This pull request is for that change. I'm pretty new to Erlang, so I won't be insulted if you have to change it around. I only care about duplicate key errors in my particular case, so I only put in one "define" in the .hrl for that error. Obviously, others can be added as they are needed.
Thanks again and let me know if you need anything farther. It's nice to "meet" you.
Jeremy
jeremy.hood@ericsson.com