Skip to content

Apply filename transforms to generated directories#358

Merged
jkwill87 merged 9 commits into
jkwill87:mainfrom
hsqwq:apply-directory-postprocessing
May 22, 2026
Merged

Apply filename transforms to generated directories#358
jkwill87 merged 9 commits into
jkwill87:mainfrom
hsqwq:apply-directory-postprocessing

Conversation

@hsqwq

@hsqwq hsqwq commented May 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Apply the existing filename post-processing pipeline (replace_after, --scene, --lower, and sanitization) to generated directory components.
  • Process relative configured directories while preserving stable absolute path prefixes.
  • Process directory components emitted by movie_format / episode_format, so nested template paths behave consistently with filenames.

Addresses #184.

Tests

  • python3.12 -m venv .venv
  • python -m pip install -e . pytest
  • python -m pip install 'ruff~=0.15.12'
  • pytest tests/local -q
  • ruff check mnamer/target.py
  • ruff format --check mnamer/target.py

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a40fdcb6e4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread mnamer/target.py Outdated
@hsqwq hsqwq force-pushed the apply-directory-postprocessing branch from a40fdcb to 983cbe6 Compare May 21, 2026 11:21
@jkwill87

jkwill87 commented May 22, 2026

Copy link
Copy Markdown
Owner

@hsqwq the omdb test failures were possible a red herring. This occasionally happens due to rate limiting of the public keys embedded in mnamer. They passed when using my personal key against your branch. I suspect 048197b may be unnecessary.

@jkwill87 jkwill87 added the bug label May 22, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 34ada63474

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread mnamer/target.py Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1bf655386e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread mnamer/target.py
Comment thread mnamer/setting_store.py
@jkwill87

Copy link
Copy Markdown
Owner

Thanks for your contribution and help closing this bug @hsqwq 😍

@jkwill87 jkwill87 merged commit f4266a6 into jkwill87:main May 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants