Installation with setting permissions#39
Open
ingo-h wants to merge 3 commits into
Open
Conversation
Remake of the Makefile for installation. The conditional installation for system and user with variable USER=1 is replaced by four rules native-install-system, native-uninstall-system, native-install-user and native-uninstall-user. This is because distinct rules simplify setting different permissions and locations.
Changed installation instruction to use native-install-system, native-uninstall-system, native-install-user and native-uninstall-user.
phdru
approved these changes
Nov 11, 2018
phdru
left a comment
phdru
left a comment
Contributor
There was a problem hiding this comment.
Looks good though I haven't tried to run it.
Owner
|
There's a lot going on here. I'm not sure the duplication introduced from removing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in issue #38 the system installation fails on my computer. The reason was that the manifest was installed in a wrong directory and permissions are not set because I use an other umask 007 that results on new directories/files to rwxr-x--- permissions. Here is my suggestion for a Makefile that sets permissions and locations that Textern needs according to Manifest location. I have set default location to
/usr/lib/mozilla/native-messaging-hosts/textern.json. For the alternative location/usr/lib64/mozilla/native-messaging-hosts/textern.jsonI have set a link. But these settings I have commented because I could not test it (that's the location my installation does not know) and in the hope that the default setup will run an any computer.