Skip to content

Fix fallback open db race condition #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
quolpr wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix fallback open db race condition #23

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56c9f4f
Fix potential fallback db open race condition
quolpr Sep 2, 2021
7ed95cc
Merge branch 'master' into fix-race-condition
quolpr Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/indexeddb/file-ops-fallback.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,24 +42,24 @@ async function openDb(name) {
class Persistance {
constructor(dbName, onFallbackFailure) {
this.dbName = dbName;
this._openDb = null;
this._openDbPromise = null;
this.hasAlertedFailure = false;
this.onFallbackFailure = onFallbackFailure;
}

async getDb() {
if (this._openDb) {
return this._openDb;
getDb() {
if (this._openDbPromise) {
return this._openDbPromise;
}

this._openDb = await openDb(this.dbName);
return this._openDb;
this._openDbPromise = openDb(this.dbName);
return this._openDbPromise;
}

closeDb() {
if (this._openDb) {
this._openDb.close();
this._openDb = null;
if (this._openDbPromise) {
this._openDbPromise.then((db) => db.close());
this._openDbPromise = null;
}
}

Expand Down