feat: meeting coordination UI — Schedule meeting from connections list#298
Merged
feat: meeting coordination UI — Schedule meeting from connections list#298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stores/meetings.ts— Pinia store withrequestMeeting,fetchMeetings,cancelMeeting; computedopenMeetingsandpendingRequestIds; full TDD (13 tests)types/meetings.ts— TypeScript mirrors of backend request/response shapesScheduleMeetingModal.vue— per-connection modal with duration selector (15/30/60/90 min), pre-populated slot checklist (next 5 weekdays × 9am/1pm/4pm, user-toggleable), optional context note; Escape/backdrop-click/auto-focus keyboard supportConnectionsSection.vue— "Schedule meeting" button per accepted connection, "meeting pending" badge when an open request exists, fetches open meetings on mount and refreshes after submissionBug discovered and fixed during review
list_connections_for_userreturned only UUIDs for connected users — butPOST /api/meetings/requestresolves targets viaget_user_by_username. Without this fix, every "Send request" click would 404. Fix: SQL now JOINs theuserstable to exposeother_username.ConnectionTypeScript type gainsother_username: string. Connection rows now show the human username rather than a truncated UUID.Test plan
Checklist
tsc --noEmitexits 0 (zero type errors)vite buildexits 0pr-review-toolkit:code-reviewerran — all findings addressed