fix: use overSlotIndex in onTimedAreaDrop to fix wrong-slot drops#309
Merged
fix: use overSlotIndex in onTimedAreaDrop to fix wrong-slot drops#309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After PR #299 landed, drops on the DayTimeline timed area were still placed at the wrong slot. The
pointer-events-nonefix on TaskCards meant drops pass through to slot divs correctly, but the container'sonTimedAreaDropwas still callingslotIndexFromClientY(e.clientY)— which depends ongetBoundingClientRect()+scrollTopand gives wrong results when the timed area is scrolled.Fix
onTimedAreaDropnow usesoverSlotIndex.value ?? slotIndexFromClientY(e.clientY):overSlotIndexis set by the slot div's@dragoverhandler via closure-capturedi— exact, no coordinate mathslotIndexFromClientYfallback only fires whenoverSlotIndexis null (drops in the hour-label gutter column, which has no slot divs)Test Added
New flow test in
DayTimelineDropZone.test.ts:dragenteron timed areadragoveron[data-time="09:00"]slot div (setsoverSlotIndex = 12)dropon container withclientY: 0(would give slot 0 via math — wrong)promoteTaskcalled withT09:00/T09:30, notT06:00Anchor-to-Anchor
The anchor→anchor drop regression (task snaps back to source) is a separate pre-existing issue — this diff does not touch
AnchorBlock.vue,useDropZone.ts, orPlanView.vue. Flagged for a separate task.Test Results
553/553 tests pass. Build: zero type errors.