Added reading pgn library from binary#30
Open
nurmukhametdaniyar wants to merge 1 commit intojmagnuson:masterfrom
Open
Added reading pgn library from binary#30nurmukhametdaniyar wants to merge 1 commit intojmagnuson:masterfrom
nurmukhametdaniyar wants to merge 1 commit intojmagnuson:masterfrom
Conversation
Author
|
I was also able to avoid issue #24 after using reading from the buffer |
Owner
|
Thanks, I like this idea. I wonder if there's a way to generalize it to take a iterator of bytes, maybe using something like |
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
- Coverage 68.88% 67.09% -1.79%
==========================================
Files 5 5
Lines 601 617 +16
==========================================
Hits 414 414
- Misses 187 203 +16
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey
I started using this library and encountered the problem where I need to read from buffer instead of reading from a file, so I added a small function to read from buffer
Hope it helps