Skip to content

src cmake performs library build #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
n9wxu wants to merge 2 commits into
base: main
Choose a base branch
from
Open

src cmake performs library build #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5e910e
src cmake performs library build
n9wxu Mar 1, 2024
101a541
fixed missing type on hex array
n9wxu Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# FIXME: Add installation directives for libgps
cmake_minimum_required(VERSION 3.25)

@jmcglad jmcglad Jul 24, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem right to put cmake_minimum_required() in anything other than the top-level CMakeLists.txt file. What's the effect of cmake_minimum_required() being called multiple times in a project?


include_directories(${CMAKE_CURRENT_SOURCE_DIR})
add_library(${PROJECT_NAME} STATIC gps.c)
if(NOT TARGET libgps)
add_library(libgps STATIC gps.c)
target_include_directories(libgps PUBLIC ${CMAKE_CURRENT_SOURCE_DIR})
endif()
2 changes: 1 addition & 1 deletion src/gps.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ static const char NULL_TIME[] = "0000-00-00T00:00:00.000Z";

static char uint8_to_hex_char(const uint8_t n)
{
static const hex[] = {
static const char hex[] = {

@jmcglad jmcglad Jul 24, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

'0', '1', '2', '3', '4', '5', '6', '7',
'8', '9', 'A', 'B', 'C', 'D', 'E', 'F'
};
Expand Down