Conversation
Align `docgen demo-function` with issue #47: `--manifest` + `--output` (keep `--output-dir` as hidden alias), cache key sha256(fn_source+intent+fixtures), Playwright test recording via `npx playwright test` when manifest sets `demonstration.spec`/`grep`, real `kind: cli` via VHS tape paths, assertion captions burned with ffmpeg subtitles, and duration trim to output_budget. Add Config.minimal and VHSRunner.render_tape_at for standalone use. Co-authored-by: John Menke <jmjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the outstanding pieces of issue #47 for
docgen demo-function:--manifestand--output(directory);--output-dirremains as a hidden backward-compatible alias.demonstration.spec+demonstration.grep; docgen runsnpx playwright testwith--video=onand viewport fromoutput_budget.resolution(F3).kind: clirequiresdemonstration.tape; renders via existing VHS runner (VHSRunner.render_tape_at), resolves tape/output relative to the manifest directory usingConfig.minimal.assertions_to_surfaceare burned in as bottom subtitles (ffmpeg WebVTT) on the visual before optional TTS mux.rendered.mp4is trimmed tooutput_budget.duration_seconds(hard cap 60s unchanged).Test plan
pytest tests/test_demo_function.py tests/test_config.py(or fulltestsminus e2e as in CI)kind: cli/ VHS tests skip whenvhsis not on PATH.