Conversation
…ssion - New workflow installs docgen from jmjava/documentation-generator@b880ba7 and runs docgen demo-function against a placeholder manifest; exit 78 is success (neutral skip per issue #9). - Regression Phase 1: auto-download Mike Farah yq to .tools/ when PATH has the unrelated PyPI yq wrapper (fixes jq -o=json confusion). - Ignore .tools/ for the downloaded binary. Co-authored-by: John Menke <jmjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue #9: there were no remaining
demo_function,docgen-shim, orPYTHONPATH=…docgen-shimreferences in this repo. This PR adds an explicit GitHub Actions smoke job that installs upstreamdocgenfrom git and invokesdocgen demo-function, treating exit code 78 as success for the intentional placeholder manifest (neutral skip).Changes
.github/workflows/docgen-demo-function.yml—pip install "docgen @ git+https://github.com/jmjava/documentation-generator.git@b880ba7a96c35fa32672f217e68c3e3592fb2be1"thendocgen demo-functionwith--no-narration; map78→0.ci/docgen-demo-function-smoke.docgen.yaml— minimal placeholder Playwright manifest (no URL) so the job is fast and deterministic.scripts/common.sh+scripts/run-regression.sh— when the wrong PyPIyqis first onPATH, auto-download Mike FarahyqtoREPO_ROOT/.tools/so Phase 1 (yq -o=jsoninstack-graph.sh) works..gitignoreignores.tools/.Verification
bash scripts/run-regression-agent.sh— exit 0 (local-only tier after env setup in the agent image).Pin note
DOCGEN_GIT_REFis set todocumentation-generator@mainHEAD at implementation time (b880ba7…) because that commit includes thedemo-functionsubcommand; the older pin in downstream docs predates that CLI.