Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a cross-site scripting (XSS) vulnerability in the on-demand query list by sanitizing user-controlled query data before rendering it in the DataTables interface. The fix prevents malicious queries from executing arbitrary JavaScript when displayed in the admin interface.
Changes:
- Added
escapeHTML()andsafeHref()helper functions in query.js to sanitize text content and validate URLs - Refactored the DataTables render function in queries.html to use jQuery DOM creation methods instead of string concatenation, ensuring automatic XSS protection
- Fixed typo in external link target attribute (
_target→target)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cmd/admin/static/js/query.js | Added escapeHTML() and safeHref() sanitization functions; updated queryResultLink() to use these functions; fixed typo in target attribute |
| cmd/admin/templates/queries.html | Refactored query column render function to use secure jQuery DOM creation methods instead of calling queryResultLink() with string concatenation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preventing unsanitized queries in the query list, that may lead to XSS.