Skip to content

Change default update check back to disabled#35

Open
C0RD wants to merge 1 commit intojmrenouard:masterfrom
C0RD:master
Open

Change default update check back to disabled#35
C0RD wants to merge 1 commit intojmrenouard:masterfrom
C0RD:master

Conversation

@C0RD
Copy link
Copy Markdown

@C0RD C0RD commented Feb 28, 2026

This reverts major@460a185

This produces a unexpected "phone-home" situation, that will also on protected systems not work due to firewalls. It should not connect to external systems if not asked for.

It was fixed in 2024 before --> major#760

Summary by Sourcery

Enhancements:

  • Change the default configuration of the version check option so that update checks are opt-in instead of enabled by default.

This reverts major@460a185

This produces a unexpected "phone-home" situation, that will also on protected systems not work due to firewalls. It should not connect to external systems if not asked for.

It was fixed in 2024 before --> major#760
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Feb 28, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Reverts the previous change that enabled MySQLTuner’s automatic update check by default, restoring the behavior where update checks are disabled unless explicitly requested.

Flow diagram for update check behavior based on default flag change

flowchart TD
    A[Start MySQLTuner] --> B[Parse command line options]
    B --> C{checkversion flag set?}

    C -->|Yes, user enabled| D[Perform update check]
    C -->|No, user did not enable| E[Skip update check]

    D --> F[Continue with tuning checks]
    E --> F[Continue with tuning checks]

    classDef default fill:#f9f9f9,stroke:#333,stroke-width:1px;
    class A,B,C,D,E,F default;
Loading

File-Level Changes

Change Details Files
Restore the default behavior so that automatic update checking is disabled unless the user opts in.
  • Change the configuration of the 'checkversion' option so its default value is 0 instead of 1, meaning no update check is performed unless explicitly enabled
mysqltuner.pl

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant