Say how the buildings and materials measurements are actually made - #512
Merged
Conversation
|
You've reached the fair usage limit for the Bito Code Review Agent trial. Upgrade to a paid plan or contact support@bito.in for assistance. Learn more |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
You've reached the fair usage limit for the Bito Code Review Agent trial. Upgrade to a paid plan or contact support@bito.in for assistance. Learn more |
|
Important Review skippedToo many files! This PR contains 117 files, which is 17 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (327)
📒 Files selected for processing (117)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
documentation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #512 +/- ##
=======================================
Coverage 97.05% 97.05%
=======================================
Files 295 295
Lines 39146 39146
=======================================
Hits 37992 37992
Misses 1154 1154 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Numerical conformance report✅ 533/533 conformance checks pass across 57 domains and 362 standards - filters class 1 - weightings within IEC 61672-1 class 1. Each row pins a standard clause to its expected normative value and the value the library computes. Every section below is collapsible and stays collapsed while all of its rows pass; a section with any failing row opens automatically. ✅ Numerical validation - filters & weightings: class showcase (IEC 61260-1 · IEC 61672-1 · ISO 7196)IEC 61260-1:2014 class per filter architecture (order 6, one-third-octave, 100 Hz-10 kHz, fs = 48 kHz). For each architecture the table shows, at its binding band, the measured relative attenuation and the class-1 limit it must clear, so the number and the range it must sit in are both visible. A positive margin means the acceptance limits are met with that much room.
Only Butterworth (the library default) and Chebyshev-II are class-compliant architectures. Chebyshev-I and elliptic trade the mask for passband ripple, and Bessel for a maximally-flat group delay (soft rolloff); they cannot satisfy the IEC 61260-1 Class 1/2 attenuation mask by construction, so they are labelled By design - this is expected, not a failure or regression. Frequency-weighting conformance (A/C: IEC 61672-1 Table 3; G: ISO 7196 A.3). The max deviation from nominal is informational (it falls at a frequency extreme where the tolerance is widest and asymmetric); compliance is judged at the binding frequency - the one with the least headroom - where the deviation, the applicable tolerance band and the headroom are shown together.
✅ Filters & weightings: 100% (10/10)
✅ Levels & dosimetry: 100% (9/9)
✅ Room & building acoustics: 100% (72/72)
✅ Room acoustics: 100% (16/16)
✅ Psychoacoustics: 100% (14/14)
✅ Speech transmission (IEC 60268-16): 100% (10/10)
✅ System measurement (Golay / Kirkeby / Mueller-Massarani): 100% (5/5)
✅ Intensity & sound power: 100% (10/10)
✅ Building prediction & uncertainty: 100% (15/15)
✅ Outdoor propagation & occupational exposure: 100% (10/10)
✅ Materials: absorption, airflow & impedance: 100% (6/6)
✅ Scattering & diffusion (ISO 17497): 100% (14/14)
✅ In-situ road absorption (ISO 13472): 100% (3/3)
✅ Precision sound power (ISO 3745 / 9614-3): 100% (4/4)
✅ Human vibration (ISO 8041 / 2631 / 5349): 100% (15/15)
✅ Speech intelligibility (ANSI S3.5-1997): 100% (24/24)
✅ Objective intelligibility (STOI / ESTOI): 100% (3/3)
✅ Impulsive-sound prominence (NT ACOU 112): 100% (2/2)
✅ Impulsive-sound prominence (ISO/PAS 1996-3): 100% (2/2)
✅ Room noise (ANSI S12.2-2019): 100% (3/3)
✅ Hearing threshold (ISO 7029 / ISO 389-7): 100% (3/3)
✅ Measurement uncertainty (GUM / Supplement 1): 100% (7/7)
✅ Noise-induced hearing loss (ISO 1999): 100% (6/6)
✅ Multiple-shock whole-body vibration (ISO 2631-5): 100% (6/6)
✅ Sound absorption in enclosed spaces (EN 12354-6): 100% (2/2)
✅ Prominent discrete tones (ECMA-418-1): 100% (2/2)
✅ Tonal audibility (ISO/PAS 20065): 100% (11/11)
✅ Psychoacoustic annoyance & fluctuation strength (Fastl & Zwicker): 100% (3/3)
✅ Electroacoustics: distortion & frequency response: 100% (20/20)
✅ Calibrated spectral analysis (Bendat & Piersol): 100% (12/12)
✅ Multiple-input coherence (Bendat & Piersol): 100% (5/5)
✅ Time-frequency analysis (Bendat & Piersol): 100% (3/3)
✅ Correlation, time delay and envelope (B&P / Knapp & Carter): 100% (7/7)
✅ Cepstrum, liftering and envelope spectrum (Havelock / B&P): 100% (3/3)
✅ Time synchronous averaging (McFadden 1987): 100% (5/5)
✅ Data qualification and Rice statistics (Bendat & Piersol): 100% (8/8)
✅ Underwater acoustics (ISO 18405/17208/18406): 100% (6/6)
✅ Underwater sound propagation (transmission loss): 100% (16/16)
✅ Underwater propagation regimes (Weston flux theory): 100% (3/3)
✅ Marine-mammal auditory weighting (NMFS / Southall): 100% (4/4)
✅ Underwater numerical propagation (modes / rays / PE): 100% (4/4)
✅ Aircraft noise (ICAO Annex 16 / IEC 61265): 100% (15/15)
✅ Rotorcraft noise (ECAC Doc 32 / NORAH2): 100% (12/12)
✅ CNOSSOS-EU road source (Directive 2002/49/EC Annex II): 100% (6/6)
✅ Wind-turbine noise (IEC 61400-11): 100% (3/3)
✅ Porous & multilayer absorbers (Mechel / Bies / Cox & D'Antonio): 100% (20/20)
✅ Slow-sound perfect absorbers (Jimenez et al. Appl. Sci. 2017): 100% (3/3)
✅ Program loudness (ITU-R BS.1770 / EBU R 128): 100% (8/8)
✅ 2D FDTD wave simulation (Attenborough & Van Renterghem 2021, Ch. 4): 100% (4/4)
✅ Swept-sine distortion & phase utilities (Farina / Novak): 100% (7/7)
✅ Spherical ground & barriers (Attenborough / Salomons / Bies): 100% (7/7)
✅ Panel & aperture sound insulation (Bies / Hopkins / Cremer): 100% (17/17)
✅ Bending-wave plate-junction transmission (Cremer / Craik / Hopkins): 100% (6/6)
✅ Atmospheric refraction (Salomons rays / GFPE): 100% (3/3)
✅ Electroacoustics: 100% (9/9)
✅ Industrial noise control: 100% (22/22)
✅ CNOSSOS-EU railway source (Directive 2002/49/EC Annex II): 100% (8/8)
Tests & coverage — 48204 tests, 0 failures (✅ all green)
Conformance harness: |
The audit reached the same verdict from fourteen independent readings: the best-written theory in the corpus, and the worst instrumented. The prose derives the quantity and then does not say how to obtain it. This closes 235 findings across thirty-five guides. New sections state the equipment and its class, the transducer positions and counts, the procedure, the validity and acceptance criteria, and the failure modes that invalidate a result without announcing themselves, taken from the clause rather than from memory: ISO 16283-1/-2/-3, ISO 10140-4/-5, ISO 15186, ISO 10052, ISO 10848, ISO 354, ISO 9053-1/-2, ISO 10534-1/-2, ISO 3382-1/-3, ISO 17497-1/-2, EN 29052-1 and ISO 13472-1. Numbers that were wrong are recomputed rather than copied from the audit, which proposed several of them wrongly. The reception-plate examples were based on an invented plate and now use the conforming one, which changes every printed result; D_C is no longer described as always positive; the mass-ratio trap in the junction model returned -0.3 dB where the answer is 12.5 dB. Eighteen new plates and figures, every one generated by the library in four variants, among them the ISO 16283-3 façade section, the ISO 16251-1 mock-up, the three heavy impact sources over one slab, the Annex L building with its thirteen paths, and two spectra that both rate NC-40 plotted against their own RC reference.
Thirty-five Spanish pages brought level with the English of this branch: the new acquisition sections, the nine new setup plates and figures with their Spanish variants, and the corrected numbers.
The register sweep replaced «cláusula» with «apartado» by substitution and kept the capital the old word had been given, which is not how Spanish cites a clause and in three places is not Spanish at all: «de el Apartado 8 e)» rather than «del apartado 8 e)». One of the three had wrapped across a line, so the obvious search does not find it. Twenty-seven references now read as the corpus already read them 658 times against these 42. The one capital that survives opens a sentence and belongs. Corrected here rather than in the branch below, which is already reviewed.
Spanish names the cause and then says what happens to the quantity. It has words for the coincidence frequency, the coincidence angle and the coincidence effect, and for the fall in R(f) itself it writes a sentence: "el aislamiento acústico disminuye", "una disminución del aislamiento", "una merma importante del aislamiento". It does not have a noun for the feature. "Valle de coincidencia" and "caída de coincidencia" appear zero times across 520 Spanish documents: the maintainer's course archive, twenty-six books, the UNE adoptions and 7,464 documents of the Sociedad Española de Acústica. The corpus used one of them nineteen times, on its own authority. Recast, sentence by sentence, into what the sources write: the fall of the insulation at coincidence, the fall of R at coincidence, or simply coincidence where the sentence already names f_c. Two of the recasts needed a second pass, one for a doubled preposition and one for an adjective still agreeing with the noun that had gone. This is the second term to resolve this way, after solver. Both were reached the same way: a plausible word that no source uses, chosen because the question was assumed to be which noun rather than whether there is one.
Four terms had exhausted the evidence: 26 Spanish books, the UNE adoptions, 520 documents of a Spanish acoustics degree and 7,464 of the Sociedad Española de Acústica, and none of them settled these. The maintainer, who is a Spanish acoustics engineer and the reader these pages are written for, ruled on them. They are recorded as his rulings rather than as citations, because a decision and a source are different things and a later pass has to be able to tell them apart. Tone burst becomes "ráfaga tonal". The adjective is what was needed: in this same register "ráfaga" already names the burst error of digital audio, a burst of data traffic, and the oscilloscope's single-shot mode, and none of them is a gated tone. Thirty-two occurrences. A solver is named by its method, never by an object that runs it: el método FDTD, and the same for BEM and FEM, which the pages already phrased that way. Detrending is "la eliminación de tendencia", and this one the sources do support, with three independent Spanish theses. Two occurrences carried a masculine article left behind by an earlier mechanical substitution. Display gain is recast rather than named: "la ganancia representada en" the panel. It describes what is drawn, not a gain applied to a signal, and these pages discuss electrical gain a few lines away, so a noun would collide. The method now records the maintainer as the authority of last resort, after the standards, the literature and the corpus, with the instruction to ask rather than guess.
jmrplens
force-pushed
the
docs/buildings-and-materials-practice
branch
from
August 8, 2026 18:20
4d51a8a to
27cc454
Compare
Four panel figures had their y-axis relabelled from "Sound reduction index R" to "Sound reduction index $R$ (transmission loss $TL$)", so that a reader who knows the quantity by either name finds it. The label changed in the generator and the committed SVGs did not, so the pages kept showing the old one and CI caught the drift. Three figures added in the same wave had never been rendered from their final generator either. Twenty-two files, seven figures in their four variants. The staleness check compares the working tree against HEAD; it does not regenerate. Running it alone therefore compares the committed files with themselves and always passes, which is why this reached CI: the local verification ran the comparison without the regeneration that gives it meaning. The verification script now runs the generators first.
|
You've reached the fair usage limit for the Bito Code Review Agent trial. Upgrade to a paid plan or contact support@bito.in for assistance. Learn more |
1 similar comment
|
You've reached the fair usage limit for the Bito Code Review Agent trial. Upgrade to a paid plan or contact support@bito.in for assistance. Learn more |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The audit that produced this branch reached the same verdict from fourteen independent readings: the best-written theory in the corpus, and the worst instrumented. The prose derives the quantity and then does not say how to obtain it. This is the second half of that contract for buildings and materials: how the number was obtained, and what it means.
235 findings closed across thirty-five English guides, and the thirty-five Spanish twins brought level with them.
Acquisition, from the clause rather than from memory
New sections state the equipment and its class, the transducer positions and counts, the procedure, the validity and acceptance criteria, and the failure modes that invalidate a result without announcing themselves: ISO 16283-1/-2/-3, ISO 10140-4/-5, ISO 15186, ISO 10052, ISO 10848, ISO 354, ISO 9053-1/-2, ISO 10534-1/-2, ISO 3382-1/-3, ISO 17497-1/-2, EN 29052-1, ISO 13472-1.
Numbers that were wrong
The corrections are recomputed, not copied from the audit, which proposed several wrongly:
D_Cis no longer described as always positive; the 8.5 dB comment is 9.86 dB;overall_levelis flagged as not A-weighted, 44.0 dB against 29.3 dB(A).Eighteen new plates and figures
Every one generated by the library, in four variants. Among them: the ISO 16283-3 façade section with the loudspeaker at 45°±5° and the 10/3 mm microphone tolerances; the ISO 16251-1 mock-up with its 1200×800×200 mm slab on four pads; the three heavy impact sources over one slab with the JIS Annex C chain; the ISO 12354-1 Annex L building with all thirteen paths numbered; and
nc_blind_spot, which draws two spectra that both rate NC-40, duct rumble and diffuser hiss, and then plots each against its own RC reference to show what the criterion cannot separate.Both languages
The Spanish pages carry the same sections, figures and numbers, and were written in the terminology settled by the register review that landed in #511:
apartado,trayectoria,elemento de ensayoagainstprobeta,hoja de características,franja de base.One defect of that review is corrected here rather than there, since it was already reviewed: it had replaced
cláusulawithapartadoby substitution and kept the capital, which in three places producedde el Apartado 8 e)rather thandel apartado 8 e). One of the three had wrapped across a line.Checks
The full CI set was run locally: the thirteen Python gates and the eleven the site job runs, including the build, HTML validation, KaTeX, the accessibility audit, the sidebar check and the visual audit. Twenty five of twenty five. A terminology checker over the Spanish tree reports zero warnings.