Closer dkP r33 support#129
Closer dkP r33 support#129arefdsg wants to merge 1 commit intojoedj:masterfrom spotlightishere:master
Conversation
|
Can you please explain this PR a bit better? I've forgotten a lot of this code, but happy to merge in general. |
| static char result[MAXPATHLEN]; | ||
| strncpy(result, path, MAXPATHLEN - 1); | ||
| result[MAXPATHLEN - 1] = '\0'; | ||
| static char result[MAXNAMLEN]; |
There was a problem hiding this comment.
Why define MAXPATHLEN, and then switch usages to MAXNAMLEN? I haven't actually tried to build this new code...are we still using MAXPATHLEN for other things?
|
|
||
| struct stat st; | ||
| int fd = fileno(f); | ||
| if (fstat(fd, &st)) return; |
There was a problem hiding this comment.
Any reason to remove this? I can't remember, but assume it was probably there for a reason :/
|
Hi - I wrote this code in a fork, and after needing a copy of ftpii all this time later found out that it had been PR'd without any notification or contact. This shouldn't work, namely as I just was trying to get the source to compile and gave up later. I've since deleted the fork and I apologize for the confusion. |
3 participants
closer