Remove multi-provider config from tdns#245
Conversation
Bite 9b step 4 of the MP config cutover. The multi-provider feature
now lives entirely in tdns-mp (under tdns-mpagent, tdns-mpsigner,
tdns-mpcombiner, tdns-mpauditor); standalone tdns-agent and
tdns-auth lose MP capability with this commit.
Deletes:
- MultiProviderConf struct + the MultiProvider field on Config.
- Sub-types: PeerConf, LocalAgentApiConf, LocalAgentDnsConf,
ProviderZoneConf, MessageRetentionConf (was only used by
LocalAgentDnsConf).
- Option enums: CombinerOption, SignerOption, AgentOption +
StringTo*/*ToString maps + CombinerOptAddSignature constant.
- LocalIdentity() accessor on *Config.
- parseMultiProviderOptions() + its call from ParseConfig.
- normalizeConfigIdentities() — its body was entirely MP fields.
- ConfigResponse.CombinerOptions field + the apihandler_funcs.go
population site + tdns-cli's rendering. (tdns-mpcli combiner
config status -v is now the home for combiner-side config
introspection.)
- AgentMgmtResponse.AgentConfig (MultiProviderConf) — dead field
on the tdns side, never read or written.
- Multi-provider role-match validation in ParseConfig (B9b-5).
- Commented-out buildChunkQueryEndpoint dead code.
Behavioural changes:
- tdns-agent with a primary zone is now unconditionally a
ConfigError ("tdns-agent does not support primary zones; use
tdns-mpagent for multi-provider roles"). Was previously allowed
if multi-provider.identity matched (B9b-6 simplification).
- tdns-cli "config status" no longer renders combiner options.
Use "tdns-mpcli combiner config status [-v]" instead.
The OptMultiProvider zone option is preserved — tdns-mp uses it
to mark zones as multi-provider. It's a zone-level flag, not a
config field.
Verified: all 5 tdns binaries (tdns-auth, tdns-agent, tdns-imr,
tdns-cli, dog) build clean. All 5 tdns-mp binaries (against this
modified tdns via the local replace directive) build clean.
This commit must NOT land before the tdns-mp side bite 9b PR
(commits 04b7229, 9fde0e0, 0f8e473 on mp-config-cutover) is on
origin/main. The tdns-mp side is the runtime source of truth for
MP config now; deleting it from tdns first would leave tdns-mp
unable to build.
Plan: tdns-mp/docs/2026-05-28-bite-9b-plan.md
|
Warning Review limit reached
More reviews will be available in 40 minutes and 39 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
Bite 9b step 4 of the MP config cutover. The multi-provider feature
now lives entirely in tdns-mp (under tdns-mpagent, tdns-mpsigner,
tdns-mpcombiner, tdns-mpauditor). Standalone tdns-agent and
tdns-auth lose MP capability with this commit.
What's deleted
`ProviderZoneConf`, `MessageRetentionConf` (was only used by
`LocalAgentDnsConf`).
the `StringTo*` / `*ToString` maps + the
`CombinerOptAddSignature` constant.
read or written).
Behavioural changes
Was previously allowed if `multi-provider.identity` matched the
zone name. Use `tdns-mpagent` for multi-provider agent roles.
Use `tdns-mpcli combiner config status [-v]` instead.
its config. Use `tdns-mpsigner` for the multi-provider signer.
What's preserved
to identify MP zones. It's a zone-level flag, not a config field.
Strict ordering requirement
This PR is the tdns half of Bite 9b. The tdns-mp half is on
tdns-mp PR #31
(branch `mp-config-cutover`, commits `04b7229` through `0801d9c`).
Both halves must land for the cutover to be complete. This PR
should merge first, so that tdns-mp can then bump its tdns version
pin to a tdns commit that has the deletes applied. Without that
ordering, an updated tdns-mp would temporarily target a tdns
version where `tdns.MultiProvider` still exists (harmless, but
muddier).
Test plan
tdns-imr, tdns-cli, dog) compile.
tdns-mpsigner, tdns-mpcombiner, tdns-mpauditor, tdns-mpcli)
compile against this tdns via the local `replace` directive.
tested clean. Bite 9b additionally needs:
all start cleanly with realistic configs.
output.
new "tdns-agent does not support primary zones" error.
Plan reference
Full execution plan in
tdns-mp/docs/2026-05-28-bite-9b-plan.md.
Findings carry stable IDs (B9b-N) that map to the deletes here.