Add PR template instruction to AGENTS.md - #4
Closed
johanzander wants to merge 1648 commits into
Closed
Conversation
Co-authored-by: Stefan Agner <stefan@agner.ch>
Co-authored-by: Stefan Agner <stefan@agner.ch>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…t#155981) Co-authored-by: Joostlek <joostlek@outlook.com> Co-authored-by: emontnemery <erik@montnemery.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…65379) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…5515) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Tao Jiang <tao.jiang@linkplay.com> Co-authored-by: Erik Montnemery <erik@montnemery.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Paulus Schoutsen <balloob@gmail.com> Co-authored-by: Joostlek <joostlek@outlook.com>
…on (home-assistant#165009) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…165996) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ssistant#165927) Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Norbert Rittel <norbert@rittel.de>
HA renamed "services" to "actions" in the UI. Update the remaining exception message in strings.json that still used the old term. Fixes review comment by @NoRi2909 on home-assistant#165927. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…able labels in exception messages Use proper English in translated exception messages instead of internal Python parameter names. Charge power, discharge power, SOC limits and time-format errors now show user-friendly labels (e.g. "Charge power", "Period 1 start") rather than snake_case identifiers. Update tests to match the new field_name values. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…#165959) Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
…ld wording - Use third-person singular for all action descriptions (Reads/Writes/Updates) - Fix write_ac_charge_times and write_ac_discharge_times device_id field description from "to read from" to "to write to" Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Improves readability and provides a hint to translators that these are field names, not generic text. Dynamic placeholders are left unquoted as ICU message format does not allow placeholders inside single quotes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rge_times The name field "Device" is shared with read actions so it can be referenced rather than duplicated as a literal string. Both write actions point directly to read_ac_charge_times for the name to avoid chained references (Lokalise only supports one level of indirection). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
All four SPH actions (read/write AC charge/discharge times) now reference the neutral "The Growatt device to perform the action on." from read_time_segments instead of action-specific "to read from"/"to write to" wording. All references point directly to read_time_segments to avoid chained references (Lokalise only supports one level of indirection). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…t errors
Replaces the single invalid_time_format key (which embedded a hardcoded
English field name as a placeholder) with four separate translatable keys:
invalid_time_format_start_time, invalid_time_format_end_time,
invalid_time_format_period_start, invalid_time_format_period_end.
This ensures non-English translations do not have English words embedded
in otherwise-translated error messages. Period keys use a {period}
numeric placeholder which requires no translation.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Norbert Rittel <norbert@rittel.de>
The GitHub UI suggestion added quoted period field names without removing
the originals or closing their braces, resulting in duplicate keys and
invalid JSON. Keep only the quoted versions: 'Period {period} end' and
'Period {period} start', consistent with other field name messages.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…dd end time test - Fix _parse_time_str to actually parse seconds when HH:MM:SS format is provided, instead of silently discarding them - Add test for invalid period end time (invalid_time_format_period_end) to complement the existing period start time test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…SS and add end time test" This reverts commit faa14ff.
Instruct AI agents to always use the repo's PULL_REQUEST_TEMPLATE.md when creating pull requests, rather than inventing a custom format. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Be explicit that all HTML comments and metadata must be kept intact, not just the section structure. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Adds an instruction to
AGENTS.md(whichCLAUDE.mdsymlinks to) telling AI agents to always use the repo's.github/PULL_REQUEST_TEMPLATE.mdwhen creating pull requests, rather than generating a custom format.Type of change
Additional information
Checklist
ruff format homeassistant tests)