This repository was archived by the owner on Apr 27, 2024. It is now read-only.
Add register once function#23
Open
cdevine49 wants to merge 1 commit into
Open
Conversation
john-doherty
suggested changes
Jul 8, 2021
| * @returns {void} | ||
| */ | ||
| function register_once(data) { | ||
| unpersistedData = Object.keys(data = {}).reduce(function (acc, key) { |
Owner
There was a problem hiding this comment.
I'm struggling to understand what's happening here... could this be refactored to improve readability?
Contributor
Author
There was a problem hiding this comment.
The idea is to only register data that hasn't already been registered. The reduce is building a new object out of the data based on which keys haven't been added to properties already. Then I'm registering that new object using the regular register function. To me, this is the clearest way to do that, but if you have a preference for another style I can try changing it.
Owner
There was a problem hiding this comment.
Sorry, a "bit" late to this. Chat GPT suggested the following (based on your code):
/**
* Register a set of super properties unless they are already added.
* @param {object} data - JSON key/value pair of properties to register.
* @returns {void}
*/
function register_once(data) {
var unpersistedData = {};
// Check each property in the input data
Object.keys(data).forEach(function(key) {
// If the property does not exist in _properties, add it to unpersistedData
if (!_properties[key]) {
unpersistedData[key] = data[key];
}
});
// Register the new properties that were not already present
register(unpersistedData);
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.