Move inline CSS from App render to static App.css#10
Draft
Copilot wants to merge 2 commits intofeat/upgrade-to-jsxfrom
Draft
Move inline CSS from App render to static App.css#10Copilot wants to merge 2 commits intofeat/upgrade-to-jsxfrom
Copilot wants to merge 2 commits intofeat/upgrade-to-jsxfrom
Conversation
Co-authored-by: john20xdoe <14521605+john20xdoe@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update JSX upgrade based on feedback in PR #9
Move inline CSS from App render to static App.css
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The entire stylesheet was embedded as a JSX
<style>string insideApp's render, causing style recalculation on every state change (e.g., accordion toggles).Changes
src/App.css— extracted all styles into a static file; Vite bundles and fingerprints it at build timesrc/App.jsx— replaced<style>{...}</style>block withimport "./App.css"index.html— replaced the@importURL inside the CSS string with a proper<link rel="stylesheet">for Google Fonts, alongside the existing preconnect hintsBefore:
After:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.