Conversation
- Model opt is passed to the -m flag of the codex command - Single border is no longer a duplicate of rounded
- BREAKING CHANGE: Buffer toggle was originally assigned to <Esc>, now assinged to <q>. This change is to not conflict with Codex CLI's newer methodology of handling agent interupts, via <Esc><Esc>. - Buffer now backgrounds smoothly, without any delay upon q press
Closed
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for selecting a specific AI model via the -m flag, refactors buffer creation/reuse, and updates tests, documentation, and CI workflows to align with these changes.
- Introduce
modeloption in config and include-m <model>in spawned command - Refactor buffer setup into
create_clean_bufwith reuse logic - Update tests for table-based
cmdand add new model-passing spec - Refresh README and adjust Makefile/CI configs
Reviewed Changes
Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/specs/codex_spec.lua | Updated cmd usage, added model test, remove debug code |
| makefile | Point test runner at tests/specs/ directory |
| lua/codex/init.lua | Add model config, buffer creation helper, inject flag |
| README.md | Document new model option and keybinding changes |
| .github/workflows/ci.yml | Remove extra branch, add semantic-release job |
Comments suppressed due to low confidence (2)
tests/specs/codex_spec.lua:50
- This print statement and the manual buffer-modified reset appear to be leftover debug code—consider removing them to keep tests clean and avoid noisy output.
print('🔍 buffer modified before toggle:', vim.api.nvim_buf_get_option(buf, 'modified'))
tests/specs/codex_spec.lua:62
- The syntax here places
'1000'outside thecmdtable; usecmd = { 'sleep', '1000' }to pass both elements correctly as a list.
require('codex').setup { cmd = 'sleep', '1000' }
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.