Draft
Conversation
eanokian
commented
Mar 13, 2026
munoztd0
reviewed
Mar 13, 2026
munoztd0
reviewed
Mar 13, 2026
munoztd0
reviewed
Mar 13, 2026
Collaborator
munoztd0
left a comment
munoztd0
left a comment
There was a problem hiding this comment.
Made a few suggestions, let me know if you disapprove them
Co-authored-by: David Muñoz Tord <david.munoz@mailbox.org>
gmbecker
reviewed
Mar 13, 2026
Collaborator
Author
I think I have addressed all your comments, now waiting for @gmbecker to confirm if his feedback has been addressed. |
munoztd0
approved these changes
Mar 16, 2026
gmbecker
reviewed
Mar 16, 2026
Collaborator
|
converted to draft until upstream PR is merged |
….com/johnsonandjohnson/junco into 225_tt_to_tlgrtf_vectorize_colwidths
… 225_tt_to_tlgrtf_vectorize_colwidths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
IMPORTANT!!
This PR depends directly on another PR in tidytlg: pharmaverse/tidytlg#63
Do not approve and merge into dev until the tidytlg PR is approved.
Fixes #225
In
tt_to_tlgrtf()we now pass vectorized colwidths togentlg(), which makes the column widths in the 'allparts' .rtf files match the individual parts.Checks