Open
Conversation
Added Linux support to example project
|
Constructive critic: This is not the way to contribute to a package. With all due respect, you have a lot of code which is doing non neccessary/non-performant things. Thanks for the effort but my recommendation would be that if you want to add or change features please discuss with community and code owner first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have continued working on the package in my fork.
Waited for the pr to get merged before opening a new one.
Here are the list of the changes I think exist in this pr:
Adding set and get volume
Added volume up down and get status functions
Added support to oppening browser links.
Added TTS option
Added support for closing open app
Youtube support?
Moved to Multicast version