Implement offline queue#1114
Closed
parrth20 wants to merge 4 commits intojoinmarket-webui:v2from
Closed
Conversation
parrth20
added
enhancement
Collaborator
|
Closing, as this is not yet to be considered for v2. I think it is better to fail hard if there is an error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr adds an offline action queue for v2 wallet actions so user operations are not lost when network/api connectivity drops.
what i have changed
added centralized connectivity detection (browser offline + api unreachable)
added persisted offline queue with action payload + metadata + status
added background retry processor with exponential backoff
integrated queue flow for:
send
import wallet
rescan chain
fee settings updates
added global queue ui showing queued/retrying/failed states
added manual controls: retry now and cancel
fixed token refresh behavior so offline refresh failures do not force logout
@theborakompanioni please give me your feedback :
does this queue scope look right for v2 (send/import/rescan/fee updates)?
is local persistence policy acceptable for queued actions in this release?
is the offline token-refresh behavior (no forced logout on connectivity failures) acceptable from product/security perspective?
I have sent you one video regarding this on element please go through it also.
fixes #1113